Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_zero is type-unstable #1359

Closed
gdalle opened this issue Mar 25, 2024 · 1 comment
Closed

make_zero is type-unstable #1359

gdalle opened this issue Mar 25, 2024 · 1 comment

Comments

@gdalle
Copy link
Contributor

gdalle commented Mar 25, 2024

Is it inevitable?

julia> using Enzyme, JET

julia> x = rand(2, 3);

julia> JET.@test_opt Enzyme.make_zero(x)
JET-test failed at REPL[55]:1
  Expression: #= REPL[55]:1 =# JET.@test_opt Enzyme.make_zero(x)
  ═════ 1 possible error found ═════
  ┌ make_zero(prev::Matrix{Float64}) @ EnzymeCore /home/guillaume/.julia/packages/EnzymeCore/XBDTI/src/EnzymeCore.jl:232
  │┌ make_zero(prev::Matrix{Float64}, ::Val{false}) @ EnzymeCore /home/guillaume/.julia/packages/EnzymeCore/XBDTI/src/EnzymeCore.jl:232
  ││┌ make_zero(::Type{Matrix{Float64}}, seen::IdDict{Any, Any}, prev::Matrix{Float64}, ::Val{false}) @ Enzyme.Compiler /home/guillaume/.julia/packages/Enzyme/l4FS0/src/compiler.jl:1200
  │││ runtime dispatch detected: convert(::Matrix{Float64}, %15::Any)::Any
  ││└────────────────────
  
ERROR: There was an error during testing
@wsmoses
Copy link
Member

wsmoses commented May 7, 2024

Array case should be resolved by #1415

@wsmoses wsmoses closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants