Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CO] Rework csv file template #609

Closed
BonneelP opened this issue Mar 6, 2023 · 0 comments
Closed

[CO] Rework csv file template #609

BonneelP opened this issue Mar 6, 2023 · 0 comments

Comments

@BonneelP
Copy link
Collaborator

BonneelP commented Mar 6, 2023

Hello all,

I finally have more time to dedicate to pyleecan and my current objectif is to clean/improve pyleecan. Before the next release, I would like to do the following (I think we already talked about this proposal but I don't remember where):
The current csv template is composed of two tables, one for the properties and one for the methods (and other information about the class) that are completely independent. The issue is that, as the tables are side by side, when committing/merging with git, the modifications are handled line by line and it creates unnecessary conflict between the two tables. We plan to move the "Methods table" bellow the "Properties table". That way no more unnecessary line conflict. There is already a function to move the tables: https://github.com/Eomys/pyleecan/blob/master/pyleecan/Generator/Functions/move_table_script.py. I still need to update the read csv part of the class generator to be able to handle both cases (side by side or in column). As the "read csv" is separated from the generation part it should not be that hard.

What do you think about this proposal ?

Best regards,
Pierre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant