Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds cache to autocompletion mite-api requests #83 #104

Merged
merged 13 commits into from
Feb 28, 2021

Conversation

Ephigenia
Copy link
Owner

Purpose

Should speed up the autocompletion for mite new, mite list and other sub-commands.

Description of Change

Adds a 7-day cache to projects, users, clients loaded with mite-api wrapper class. The cache uses a file in the user‘s home directory: ~/.mite-cli-cache.json which uses a flat JSON hierarchy.

Todos

I’ll use this while working for the next days or weeks to verify that this feature is reliable enough. I’ll also think about adding a cache invalidation upon project, client changes using the cli.

@Ephigenia Ephigenia added the enhancement feature enhancement or refactors label Dec 2, 2020
@Ephigenia Ephigenia self-assigned this Dec 2, 2020
@Ephigenia Ephigenia force-pushed the feat/autocompletion-cache branch from 6f4e96c to 7c0b77f Compare December 11, 2020 09:56
@Ephigenia
Copy link
Owner Author

As there hasn’t been any feedback on this I’ll merge this now.

@Ephigenia Ephigenia merged commit 04d866c into develop Feb 28, 2021
@Ephigenia Ephigenia deleted the feat/autocompletion-cache branch February 28, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature enhancement or refactors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cache for auto-completions
1 participant