feat(cache): add clear cache command #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the mite data are updated (new projects, customers or services) is useful to clear the cache, in order to get the updated changes. Otherwise also if there are new projects, mite-cli will not show them, until the cache is rebuild with the fresh data from mite.
Ephigenia
reviewed
Jul 6, 2023
Ephigenia
reviewed
Jul 6, 2023
|
Thanks for your contribution! |
|
I’ve changed some minor things. Will merge it soon. There also could be a more specific cache.clear function that could be called from the "customer-new" command or similar to clear the cache automatically when the cached data is changed by a mite-cli command. |
Ephigenia
approved these changes
Jul 8, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jul 8, 2023
# [1.11.0](v1.10.4...v1.11.0) (2023-07-08) ### Features * **cache:** add clear cache command ([#241](#241)) ([007a2c3](007a2c3))
|
🎉 This PR is included in version 1.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
I faced the problem, that I could not see new project, customer or services while using mite-cli, because those were updated in mite but I was using an old cache.
I find useful to have a command to clear the cache. I don't know the codebase very well, I tried to contribute with the quick solution I build for myself.
Of course, feel free to point me in the right direction and decline the PR if there are other more elegant solutions.
Description of Change
My quick solution was directly to replace the content of the file were the cache is saved with an empty object.
Then, the next time
mite newis used, then the cache will be updated with fresh data.Todos