Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hang in rd_name_alloc when entering long arguments for target #387

Closed
rdunnington opened this issue Jan 6, 2025 · 1 comment
Closed

Comments

@rdunnington
Copy link

This was using the latest release build (v0.9.14-alpha).

Repro steps

  1. Add a target for any executable (in my case it was zig.exe).
  2. Set the following string as the arguments:
E:\Dev\third_party\zig\build\stage4\bin\zig.exe build-obj -cflags -IE:\dev\handmade\orca\src -isystem E:\dev\handmade\orca\src\orca-libc\src\include -isystem E:\dev\handmade\orca\src\orca-libc\src\include\private -IE:\dev\handmade\orca\src\orca-libc\src\arch -IE:\dev\handmade\orca\src\orca-libc\src\internal -Wall -Wextra -Werror -Wno-null-pointer-arithmetic -Wno-unused-parameter -Wno-sign-compare -Wno-unused-variable -Wno-unused-function -Wno-ignored-attributes -Wno-missing-braces -Wno-ignored-pragmas -Wno-unused-but-set-variable -Wno-unknown-warning-option -Wno-parentheses -Wno-shift-op-parentheses -Wno-bitwise-op-parentheses -Wno-logical-op-parentheses -Wno-string-plus-int -Wno-dangling-else -Wno-unknown-pragmas -D__ORCA__ -DBULK_MEMORY_THRESHOLD=32 --std=c11 -- E:\dev\handmade\orca\src\orca-libc\src\math\cbrtf.c -fsingle-threaded -OReleaseSmall -target wasm32-freestanding -mcpu baseline+bulk_memory+nontrapping_fptoint -Mroot --cache-dir E:\dev\handmade\orca\.zig-cache --global-cache-dir C:\Users\Reuben\AppData\Local\zig --name libc_math_cbrtf.c --zig-lib-dir E:\dev\handmade\orca\src\orca-libc
  1. Observe hang
  2. Observe that the full arguments don't seem to be pasted into the text input box

image

I managed to grab the site of the hanging callstack as well:

raddbg.exe;String8  rd_name_alloc(
   String8  string = { ... }) Ln 1274;7FF6D10C3584
raddbg.exe;rd_entity_equip_name();7FF6D109FBC3
raddbg.exe;rd_eval_space_write();7FF6D10A3CF4
raddbg.exe;rd_commit_eval_value_string();7FF6D109D57C
raddbg.exe;rd_watch_view_build();7FF6D10D0E91
raddbg.exe;rd_view_rule_ui_targets();7FF6D0FD2335
raddbg.exe;rd_window_frame();7FF6D11094CC
raddbg.exe;rd_frame();7FF6D10BC0ED
raddbg.exe;entry_point();7FF6D1051DCD
raddbg.exe;w32_entry_point_caller();7FF6D1150ABE
raddbg.exe;wWinMain();7FF6D1150B7D
raddbg.exe;__scrt_common_main_seh();7FF6D1151C92
kernel32.dll;;7FFB0CFD7374
ntdll.dll;;7FFB0D9DCC91
@ryanfleury
Copy link
Collaborator

Fixed in bc44f58.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants