Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OneHotEncoder and OrdinalEncoder #588

Open
jay-m-dev opened this issue Jul 13, 2023 · 0 comments
Open

Add OneHotEncoder and OrdinalEncoder #588

jay-m-dev opened this issue Jul 13, 2023 · 0 comments

Comments

@jay-m-dev
Copy link
Contributor

jay-m-dev commented Jul 13, 2023

Add a OneHotEncoder and OrdinalEncoder. In a previous commit (# 9edbbce) these were removed. We should put back the Encoders in the validateDataset step to allow uploading datasets with ordinal and categorical columns.

This functionality was part of Aliro prior to the 9edbbce commit. But, experiments could not be run. It seems the Encoders were never implemented when running experiments. So, this issue will require 2 steps:

  1. Put back the encoders in the validateDataset step
  2. Perform encoding when a new experiment is launched.

Testing of this feature can be done with the datasets in data/datasets/test/integration/

Once this is implemented, we'll need to put back the skipped unittests in learn_tests.py and test_validateDataset.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant