Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full output (stderr, stdout) in install and code run endpoints #597

Closed
jay-m-dev opened this issue Sep 1, 2023 · 0 comments · Fixed by #599
Closed

Add full output (stderr, stdout) in install and code run endpoints #597

jay-m-dev opened this issue Sep 1, 2023 · 0 comments · Fixed by #599
Assignees
Labels
Backend being worked on enhancement javascript Pull requests that update Javascript code
Milestone

Comments

@jay-m-dev
Copy link
Contributor

The /execapi/v1/executions/install endpoint does not return the full output.

Example:
calling the endpoint with this parameters:

{
  "command": "install",
  "packages": ["test"]
}

returns:

{
    "command": "install",
    "packages": [
        "test"
    ],
    "exec_results": {
        "stderr": "WARNING: You are using pip version 22.0.4; however, version 23.2.1 is available.\nYou should consider upgrading via the '/usr/local/bin/python -m pip install --upgrade pip' command.\n",
        "code": 1
    }
}

while the full stderr output actually is:

aliro-machine-1  | 0|machine  | stderr: ERROR: Could not find a version that satisfies the requirement test (from versions: none)
aliro-machine-1  | 0|machine  | stderr: ERROR: No matching distribution found for test
aliro-machine-1  | 0|machine  | stderr: WARNING: You are using pip version 22.0.4; however, version 23.2.1 is available.
aliro-machine-1  | 0|machine  | You should consider upgrading via the '/usr/local/bin/python -m pip install --upgrade pip' command.
aliro-machine-1  | 0|machine  | child process exited with code 

NOTE: the code run (/execapt/v1/executions) endpoint captures output in the same way as the /install endpoint. Make sure the fix is applied to the /executions endpoint as well.

@jay-m-dev jay-m-dev added enhancement being worked on javascript Pull requests that update Javascript code Backend labels Sep 1, 2023
@jay-m-dev jay-m-dev linked a pull request Sep 1, 2023 that will close this issue
@jay-m-dev jay-m-dev self-assigned this Sep 1, 2023
@jay-m-dev jay-m-dev linked a pull request Sep 8, 2023 that will close this issue
@jay-m-dev jay-m-dev added this to the Aliro v0.20 milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend being worked on enhancement javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant