Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should 'classification=True' be 'classification=self.classification'? #150

Open
jgh9094 opened this issue Sep 18, 2024 · 2 comments
Open
Assignees

Comments

@jgh9094
Copy link
Contributor

jgh9094 commented Sep 18, 2024

self._search_space = get_default_search_space(self.search_space, classification=True, inner_predictors=True, **get_search_space_params)

I think the wrong argument is being passed to the classification variable?

@perib
Copy link
Collaborator

perib commented Sep 18, 2024

yes it should. Also I noticed that some selectors are duplicated in the search space templates provided in the same file.

Also perhaps this file should be merged into get_configspace.py?

@jgh9094
Copy link
Contributor Author

jgh9094 commented Sep 18, 2024

We should be okay by maintaining a unique set of selectors after processing all of them. That way no one selector is overrepresented when mutating things.

What files/functions should be merged into get_configspace.py?

@perib perib self-assigned this Sep 18, 2024
@perib perib mentioned this issue Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants