Wall Glitch Fix and Mod Compatibility

[mrgrim]

I'm the author of a mod called "EigenCraft Unofficial Patch" located here:

https://www.github.com/mrgrim/MUP/

My mod includes a fix for MC-2025 based on the same technique yours does. Recently an incompatibility with the ExtraUtils2 "Golden Lasso" item was reported, and I implemented a general fix for cases where the stored AABB and position do not match. You can see this here:

https://www.github.com/mrgrim/MUP/blob/master/src/main/java/org/gr1m/mc/mup/bugfix/mc2025/mixin/MixinEntity.java

I also implemented the ability for my mod to detect the presence of yours and to disable the runtime configuration for Surge's version of this fix since it does not implement this compatibility feature. You can see how I did that with this commit:

mrgrim/MUP@d31cd09

I tried to use as light a touch as possible..

If you'd be willing to implement a similar fix in your mod I'd be happy to simply have mine disable its own fix when yours is detected rather than try to disable yours at runtime. Let me know what you think.

Thanks!

[Darkhax]

Hello, sorry for not replying in a very long time. I really appreciate your detailed explanation of the issue and all the precautions made when modifying Surge. I usually stop developing this mod when a new version comes out, to let things settle down a bit.

[Nevrai]

Where can I download this?

[embeddedt]

mrgrim/MUP#25

[Nevrai]

@embeddedt Thank you! Why is it not on CurseForge, by the way?

Is it possible you could fork the original project and release it on CF?

[embeddedt]

Instead of doing that I would probably just PR the useful fixes to https://github.com/LoliKingdom/LoliASM, since the license allows for that. This isn't going to happen anytime soon, though.