-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the LOST last frame in VQ MotionDataset. #51
Comments
This issue can be fixed as follows: self.lengths.append(motion.shape[0] - opt.window_size)
self.lengths.append(motion.shape[0] - opt.window_size + 1) # Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the getitem method of the MotionDataset, I found that the LAST frame of each motion segment cannot be retrieved.
For example, in the first motion,
self.cumsum[1] = 129
. Whenitem=129
, there isidx = 128
sinceidx=item-self.cumsum[motion_id=0]-1
, resulting in the motion segment being[128:128+64] = [128:192]
, while in fact, the length of this motion should be129+64=193
according to this line. This issue occurs with every subsequent motion segment. Should I submit a PR to fix this problem?The text was updated successfully, but these errors were encountered: