Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the LOST last frame in VQ MotionDataset. #51

Open
Dai-Wenxun opened this issue May 24, 2024 · 1 comment
Open

the LOST last frame in VQ MotionDataset. #51

Dai-Wenxun opened this issue May 24, 2024 · 1 comment

Comments

@Dai-Wenxun
Copy link

In the getitem method of the MotionDataset, I found that the LAST frame of each motion segment cannot be retrieved.

For example, in the first motion, self.cumsum[1] = 129. When item=129, there is idx = 128 since idx=item-self.cumsum[motion_id=0]-1, resulting in the motion segment being [128:128+64] = [128:192], while in fact, the length of this motion should be 129+64=193 according to this line. This issue occurs with every subsequent motion segment. Should I submit a PR to fix this problem?

@Dai-Wenxun
Copy link
Author

This issue can be fixed as follows:

self.lengths.append(motion.shape[0] - opt.window_size)
self.lengths.append(motion.shape[0] - opt.window_size + 1)  # Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant