Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Marketplace] - Implement BlockHeader for TestBlockHeader properly #3583

Open
ss-es opened this issue Aug 16, 2024 · 0 comments
Open

[Marketplace] - Implement BlockHeader for TestBlockHeader properly #3583

ss-es opened this issue Aug 16, 2024 · 0 comments

Comments

@ss-es
Copy link
Contributor

ss-es commented Aug 16, 2024

What is this task and why do we need to work on it?

In #3569, get_auction_results was given a dummy implementation to allow running an integration test for a consensus upgrade to the marketplace version. Once the simple builder is updated to properly serve marketplace bundles, we should make sure BlockHeader (and other traits in example-types) have correct implementations for the test types.

What work will need to be done to complete this task?

No response

Are there any other details to include?

No response

What are the acceptance criteria to close this issue?

Test types get correct implementations with all tests passing.

Branch work will be merged to (if not the default branch)

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant