Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A multiplicity different than expected can cause nodes to panic. #644

Closed
elliedavidson opened this issue Jul 31, 2024 · 2 comments · Fixed by #653
Closed

A multiplicity different than expected can cause nodes to panic. #644

elliedavidson opened this issue Jul 31, 2024 · 2 comments · Fixed by #653
Assignees

Comments

@elliedavidson
Copy link
Member

This issue was observed on version 0.4.5

Nodes will panic if they attempt to verify a VID share with a different multiplicity than the node expects. An incorrectly configured node could cause many other network nodes to crash.

To reproduce:

  • Run 1 HotShot leader with multiplicity = 2
  • Run other HotShot nodes with multiplicity = 4
  • Replica nodes will panic in the verifiy_share function in vid/src/advz.rs
@elliedavidson
Copy link
Member Author

This issue actually needs to be in HotShot: EspressoSystems/HotShot#3523

@ggutoski
Copy link
Contributor

jellyfish should not panic for that. re-opening this issue. Thanks for posting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants