Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Optionally show the loading activity as a subview of the window? #51

Open
Sweeper777 opened this issue Jun 29, 2019 · 1 comment

Comments

@Sweeper777
Copy link
Contributor

Currently, the LoadingActivity view seems to be added as a subview of the topViewController. This means that I cannot show the loading activity, and keep it showing while I perform a segue that goes to another VC.

I think adding the loading activity as a subview of the window should fix this, but this would not work if the view controller is not full screen (see #23). Therefore, I think it would be best to provide an option to add the loading activity to the window.

Either:

  • Accept a UIViewController? parameter in show. When this is nil, show the loading activity in the window, otherwise show it as a subview of the view of the VC, or
  • Accept a Bool parameter called showAsSubviewOfWindow. This won't break existing code.

Do you think this is a good idea?

@Esqarrouth
Copy link
Owner

Good idea, but repo isn't actively being maintained anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants