Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calcite Combobox "single-persist" selection mode does not prevent deselection #10163

Open
2 of 6 tasks
GealSarrett opened this issue Aug 26, 2024 · 2 comments
Open
2 of 6 tasks
Labels
0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. docs Issues relating to documentation updates only. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment.

Comments

@GealSarrett
Copy link

Check existing issues

Actual Behavior

Setting the selection mode to "single-persist" behaves identically to "single" mode. The user is allowed to use the "x" chip to remove their selection.

Expected Behavior

The user, per the documentation on the single-persist selection mode, should not be able to clear the selected item.

Reproduction Sample

https://developers.arcgis.com/calcite-design-system/components/combobox/

Reproduction Steps

  1. Open the sample page
  2. Change the selection mode to "single-persist"
  3. Select an item in the combobox
  4. Click on the gray "x" chip button in the combo-box

Reproduction Version

2.11.1

Relevant Info

Windows 11, Edge, Firefox and Chrome. No console errors/warnings.

Regression?

Not sure.

Priority impact

impact - p3 - not time sensitive

Impact

Requires adding additional scripting logic alongside the component to account for the possibility of user deselection.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

N/A

@GealSarrett GealSarrett added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Aug 26, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Aug 26, 2024
@macandcheese
Copy link
Contributor

As a workaround you can use clear-disabled property in combination with selection-mode="single-persist".

cc @DitwanP re: potential documentation update for the selection-mode prop?

@macandcheese macandcheese added the docs Issues relating to documentation updates only. label Aug 26, 2024
@geospatialem geospatialem added spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. p - low Issue is non core or affecting less that 10% of people using the library needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Sep 16, 2024
@geospatialem
Copy link
Member

Spike to determine functionality of selection-mode="single-persist" and next steps. For the spike effort refer to some discussion in #4738 for additional background/history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. docs Issues relating to documentation updates only. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment.
Projects
None yet
Development

No branches or pull requests

6 participants
@macandcheese @geospatialem @GealSarrett and others