Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Panel] popover in panel constrained to panel content #10180

Closed
2 of 6 tasks
COV-GIS opened this issue Aug 28, 2024 · 4 comments
Closed
2 of 6 tasks

[Panel] popover in panel constrained to panel content #10180

COV-GIS opened this issue Aug 28, 2024 · 4 comments
Labels
0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs triage Planning workflow - pending design/dev review.

Comments

@COV-GIS
Copy link

COV-GIS commented Aug 28, 2024

Check existing issues

Actual Behavior

As of 2.12.0 a popover in a panel is constrained to the content area of the panel excluding the title and footer areas. This can cause unnecessary y overflow/scrolling and the popup not aligning with the header action if trigger thereby.

2.12.0

image

2.11.1

image

This is particularly an issue with floating panels that may not have all the necessary height in the content area.

image

image

Expected Behavior

Popover should use the entire panel.

image

Reproduction Sample

https://codepen.io/COV-GIS/pen/RwzBgGW

Reproduction Steps

  1. Switch between the 2.11.1 and 2.12.0 resource tags.
  2. Click on the gear iconed action.

Reproduction Version

2.12.0

Relevant Info

No response

Regression?

2.11.1

Priority impact

impact - p2 - want for an upcoming milestone

Impact

It would be nice to have this fixed sooner than later.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

N/A

@COV-GIS COV-GIS added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Aug 28, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Aug 28, 2024
@geospatialem
Copy link
Member

@COV-GIS adding overlay-positioning="fixed" to the popover should mitigate the above: https://codepen.io/geospatialem/pen/vYqaeMo

<calcite-popover auto-close closable heading="Options" scale="s" overlay-positioning="fixed" placement="bottom-end">
    ...
</calcite-popover>

@driskull
Copy link
Member

This is due to the setting of the position:relative in this PR: #10117

The way to avoid this is to move the popover outside of the panel. Like so: https://codepen.io/driskull/pen/yLdqPPq?editors=1000

@COV-GIS
Copy link
Author

COV-GIS commented Aug 28, 2024

Thanks @geospatialem and @driskull.

I have tried to avoid using fixed positioning unless absolutely necessary. But looks like that will have to be the way to go in this case. Not practical to create a separate popover component to create outside the panel on account of my component having the panel element itself the root of the vnode.

Closing.


Can you answer a quick unrelated question @driskull? Why is panel (and by extension dialog) footer now focusable? And only by clicking the footer or heading; but not by tabbing. If it needs to be for accessibility or the like it should also include the top focus:

image

@COV-GIS COV-GIS closed this as completed Aug 28, 2024
@macandcheese
Copy link
Contributor

@COV-GIS We should be improving the focus behavior soon, you can track in this related issue: #10022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

4 participants