Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dialog] All keydown events trapped when escape-disabled is present #10410

Closed
2 of 6 tasks
ellenupp opened this issue Sep 26, 2024 · 3 comments
Closed
2 of 6 tasks

[Dialog] All keydown events trapped when escape-disabled is present #10410

ellenupp opened this issue Sep 26, 2024 · 3 comments
Labels
0 - new New issues that need assignment. ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs triage Planning workflow - pending design/dev review.

Comments

@ellenupp
Copy link

Check existing issues

Actual Behavior

When escape-disabled is present on a dialog, all keydown events are prevented so you can't for example tab between focusable elements or type in an input.

Expected Behavior

escape-disabled only impacts keydown on escape key

Reproduction Sample

https://codepen.io/ellupp/pen/poMJEOp?editors=1000

Reproduction Steps

  1. Try typing in the input in the dialog, nothing happens

Reproduction Version

2.12.2

Relevant Info

No response

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Impact

needed for us to start using dialog in place of modal

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Dashboards

@ellenupp ellenupp added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Sep 26, 2024
@github-actions github-actions bot added ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Sep 26, 2024
@geospatialem
Copy link
Member

@ellenupp this should be mitigated in the upcoming 2.13.0 release via #10336.

Here's an example of the verification locally if of interest:

verified

Going to mark the above as a duplicate and close it out. 👍🏻

@geospatialem geospatialem closed this as not planned Won't fix, can't repro, duplicate, stale Sep 26, 2024
@ellenupp
Copy link
Author

Ah thanks, only checked for duplicates in open issues!

@geospatialem
Copy link
Member

Ah thanks, only checked for duplicates in open issues!

Absolutely no worries, appreciate you filing so we can investigate either way! 🤜🏻🤛🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

2 participants