Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests/card] Redundant event spy created #10412

Closed
maxpatiiuk opened this issue Sep 27, 2024 · 2 comments
Closed

[Tests/card] Redundant event spy created #10412

maxpatiiuk opened this issue Sep 27, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library testing Issues related to automated or manual testing.
Milestone
2024-10-29 - Oct ...

Comments

@maxpatiiuk
Copy link
Member

Priority impact

p - low

Test type

a typo in a test

Which Component(s)

card

Unstable Tests

The following test for the calcite-card event creates two identical event spies:

calcite-design-system/packages/calcite-components/src/components/card/card.e2e.ts

Lines 91 to 92 in 699e166

const cardSelectSpy = await card.spyOnEvent("calciteCardSelect");
const clickSpy = await card.spyOnEvent("calciteCardSelect");

Based on the 2nd variable name, it seems like one of them is a typo. Was "click" event expected instead?

Test error, if applicable

No response

PR skipped, if applicable

Additional Info

No response
@maxpatiiuk maxpatiiuk added testing Issues related to automated or manual testing. 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Sep 27, 2024
@maxpatiiuk maxpatiiuk self-assigned this Sep 27, 2024
@github-actions github-actions bot added the p - low Issue is non core or affecting less that 10% of people using the library label Sep 27, 2024
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Sep 27, 2024
@jcfranco jcfranco assigned jcfranco and unassigned maxpatiiuk Sep 27, 2024
@jcfranco jcfranco added this to the 2024-10-29 - Oct Milestone milestone Sep 27, 2024
@jcfranco jcfranco added estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. and removed needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Sep 27, 2024
@jcfranco jcfranco mentioned this issue Sep 27, 2024
Merged
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Sep 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned DitwanP and unassigned jcfranco Sep 30, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Oct 2, 2024

🍡✨

@DitwanP DitwanP closed this as completed Oct 2, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library testing Issues related to automated or manual testing.
Projects
None yet
Milestone
2024-10-29 - Oct Milestone
Development

No branches or pull requests
4 participants
@jcfranco @geospatialem @maxpatiiuk @DitwanP