Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Accordion icon token naming schema #10894

Open
3 of 7 tasks
geospatialem opened this issue Nov 27, 2024 · 0 comments
Open
3 of 7 tasks

[Refactor] Accordion icon token naming schema #10894

geospatialem opened this issue Nov 27, 2024 · 0 comments
Assignees
@alisonailea
Labels
1 - assigned Issues that are assigned to a sprint and a team member. calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. design-tokens Issues requiring design tokens. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality refactor Issues tied to code that needs to be significantly reworked.
Milestone
2024-12-17 - Dec ...

Comments

@geospatialem
Copy link
Member

geospatialem commented Nov 27, 2024 •
edited
Loading

Description

  • 1. Rename the two accordion-item icon tokens:

    Current:

    • --calcite-accordion-item-end-icon-color
    • --calcite-accordion-item-start-icon-color

    Proposed:

    • --calcite-accordion-item-icon-color-end
    • --calcite-accordion-item-icon-color-start

  • 2. Update the schema diagram to include the start/end icon token as examples (for either calcite-tab or calcite-accordion-item examples

Proposed Advantages

Consistency with the proposed naming schema of [domain]-[component]-[element]-[type]-[group], similar to the proposal for tab-title proposed in this comment.

Which Component

accordion-item

Relevant Info

#10871 (comment)

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components
@geospatialem geospatialem added refactor Issues tied to code that needs to be significantly reworked. p - high Issue should be addressed in the current milestone, impacts component or core functionality 1 - assigned Issues that are assigned to a sprint and a team member. estimate - 2 Small fix or update, may require updates to tests. design-tokens Issues requiring design tokens. labels Nov 27, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. labels Nov 27, 2024
@geospatialem geospatialem mentioned this issue Nov 27, 2024
Merged
@geospatialem geospatialem added estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. and removed estimate - 2 Small fix or update, may require updates to tests. labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alisonailea alisonailea

Labels
1 - assigned Issues that are assigned to a sprint and a team member. calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. design-tokens Issues requiring design tokens. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2024-12-17 - Dec Milestone
Development

No branches or pull requests
2 participants
@alisonailea @geospatialem