Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop deprecated LoadableComponent utils #11333

Open
1 of 5 tasks
jcfranco opened this issue Jan 17, 2025 · 0 comments
Open
1 of 5 tasks

Drop deprecated LoadableComponent utils #11333

jcfranco opened this issue Jan 17, 2025 · 0 comments
Assignees
@Elijbet
Labels
1 - assigned Issues that are assigned to a sprint and a team member. estimate - 2 Small fix or update, may require updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Milestone
2025-02-25 - Feb ...

Comments

@jcfranco
Copy link
Member

Description

#11312 refactored loadable to leverage componentOnReady, so we can remove the deprecated utils.

Proposed Advantages

Leaner, simpler code.

Which Component

All components implementing LoadableComponent.

Relevant Info

Steps to simplify:

  • LoadableComponent ➡️ remove after all deprecated utils have been removed
  • setComponentLoaded, setUpLoadableComponent ➡️ remove
  • componentLoaded ➡️ use componentOnReady directly

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components
@jcfranco jcfranco added 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. refactor Issues tied to code that needs to be significantly reworked. labels Jan 17, 2025
This was referenced Jan 17, 2025
Merged
Open
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. estimate - 2 Small fix or update, may require updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 29, 2025
@jcfranco jcfranco added this to the 2025-02-25 - Feb Milestone milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Elijbet Elijbet

Labels
1 - assigned Issues that are assigned to a sprint and a team member. estimate - 2 Small fix or update, may require updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2025-02-25 - Feb Milestone
Development

No branches or pull requests
2 participants
@jcfranco @Elijbet