Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Combobox] Support editing custom single-select values, rather than re-entering new values #7174

Open
mpayson opened this issue Jun 14, 2023 · 3 comments
Assignees
Labels
1 - assigned Issues that are assigned to a sprint and a team member. ArcGIS Online Issues logged by ArcGIS Online team members. c-combobox Issues that pertain to the calcite-combobox and related components design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library

Comments

@mpayson
Copy link

mpayson commented Jun 14, 2023

Description

In order to edit a custom value in a combobox, users currently have to deselect their custom value, then enter a new value, which is respectably challenging. It'd be great if users could edit existing values

Acceptance Criteria

Users can edit existing custom combobox values that they entered, and ideally edit combobox options as well

Relevant Info

No response

Which Component

calcite-combobox

Example Use Case

We have a control in our app that allows users to select a date format, or enter a custom date format. If a user accidentally types MM/DD/yyyy hh:m.ss for a custom format instead of MM/DD/yyyy hh:mm.ss, they have to re-renter the whole value, rather than inserting an m. It's also hard to copy the current combobox value to avoid having to retype. We have a similar use case for character encodings

Priority impact

p4 - not time sensitive

Esri team

ArcGIS Online

@mpayson mpayson added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Jun 14, 2023
@github-actions github-actions bot added ArcGIS Online Issues logged by ArcGIS Online team members. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Jun 14, 2023
@mpayson
Copy link
Author

mpayson commented Jun 14, 2023

Maybe part of #6720?

@ashetland ashetland added c-combobox Issues that pertain to the calcite-combobox and related components design Issues that need design consultation prior to development. labels Jul 5, 2023
@ashetland ashetland self-assigned this Jul 5, 2023
@ashetland ashetland added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Jul 5, 2023
@ashetland ashetland added this to the Design Sprint milestone Jul 5, 2023
@ashetland ashetland added p - low Issue is non core or affecting less that 10% of people using the library and removed needs triage Planning workflow - pending design/dev review. labels Jul 5, 2023
@ashetland
Copy link
Contributor

ashetland commented Jul 7, 2023

While we explore what this interaction would entail, would the ability to delete items also be useful here? This of course brings up further questions like can the user only delete items they've added? How are these item differentiated?

@mpayson
Copy link
Author

mpayson commented Jul 12, 2023

For our use case, I'm not sure the items need to be deleted, or even if the custom values need to be added to the list. Here are some similar interactions in other libraries

@brittneytewks brittneytewks added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Sep 12, 2023
@brittneytewks brittneytewks removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - assigned Issues that are assigned to a sprint and a team member. ArcGIS Online Issues logged by ArcGIS Online team members. c-combobox Issues that pertain to the calcite-combobox and related components design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Development

No branches or pull requests

3 participants