Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError thrown during build (Sass formatter) #8121

Closed
2 of 5 tasks
jcfranco opened this issue Nov 3, 2023 · 2 comments
Closed
2 of 5 tasks

TypeError thrown during build (Sass formatter) #8121

jcfranco opened this issue Nov 3, 2023 · 2 comments
Labels
0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive spike complete Issues that have a research spike completed and dev work can proceed

Comments

@jcfranco
Copy link
Member

jcfranco commented Nov 3, 2023

Check existing issues

Actual Behavior

The following error is thrown when building tokens.

TypeError: token.value.includes is not a function
at file://.../calcite-design-system/packages/calcite-design-tokens/support/token-transformer/format/scss.ts:45:33
at Array.reduce (<anonymous>)
at Object.formatSCSS [as format] (file://.../calcite-design-system/packages/calcite-design-tokens/support/token-transformer/format/scss.ts:43:40)
at buildFile (//.../calcite-design-system/node_modules/style-dictionary/lib/buildFile.js:103:37)
at //.../calcite-design-system/node_modules/style-dictionary/lib/buildFiles.js:33:7
at Array.forEach (<anonymous>)
at buildFiles (//.../calcite-design-system/node_modules/style-dictionary/lib/buildFiles.js:31:18)
at Object.buildPlatform (//.../calcite-design-system/node_modules/style-dictionary/lib/buildPlatform.js:62:3)
at //.../calcite-design-system/node_modules/style-dictionary/lib/buildAllPlatforms.js:31:10
at Array.forEach (<anonymous>)

cc @alisonailea

Expected Behavior

No TypeError to show up.

Reproduction Sample

http://github.com/Esri/calcite-design-system/

Reproduction Steps

  1. Clone repo
  2. run npm i
  3. run tokens build npm run build --workspace=packages/calcite-design-tokens

Reproduction Version

1.10.0

Relevant Info

No response

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)

@jcfranco jcfranco added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Nov 3, 2023
@github-actions github-actions bot added impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. Calcite (dev) Issues logged by Calcite developers. labels Nov 3, 2023
@jcfranco jcfranco changed the title Sass error thrown during build TypeError thrown during build (Sass formatter) Nov 3, 2023
@geospatialem geospatialem added spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Nov 27, 2023
@geospatialem geospatialem added this to the 2023 December Priorities milestone Nov 27, 2023
@jcfranco
Copy link
Member Author

This is no longer applicable with the changes introduced by #8215 (v2). Closing!

@jcfranco jcfranco added the spike complete Issues that have a research spike completed and dev work can proceed label Nov 27, 2023
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Nov 27, 2023
@github-actions github-actions bot removed this from the 2023 December Priorities milestone Nov 27, 2023
Copy link
Contributor

cc @geospatialem, @brittneytewks

@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive spike complete Issues that have a research spike completed and dev work can proceed
Projects
None yet
Development

No branches or pull requests

2 participants