Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter dropdown graphics don't support RTL #941

Closed
MikeTschudi opened this issue Apr 11, 2018 · 1 comment
Closed

Filter dropdown graphics don't support RTL #941

MikeTschudi opened this issue Apr 11, 2018 · 1 comment
Assignees

Comments

@MikeTschudi
Copy link
Member

Using the example http://esri.github.io/calcite-web/documentation/patterns/#filter-dropdown and adding dir="rtl" to the html tag, one sees

image

image

Adding the following CSS appears to fix this for Chrome 65, Firefox 59, Edge 41, IE 11:

html[dir="rtl"] .filter-dropdown-link {
  padding: 0.51667rem 2rem 0.51667rem 1.55rem;
}

html[dir="rtl"] .filter-link-check {
  opacity: 0;
  visibility: hidden;
  margin-top: 6px;
  position: absolute;
  left: auto;  /* for IE11 */
  left: unset;
  right: 9px;
}

html[dir="rtl"] .filter-link-close {
  opacity: 0;
  visibility: hidden;
  margin-top: 6px;
  position: absolute;
  left: 9px;
  right: auto;  /* for IE11 */
  right: unset;
}

html[dir="rtl"] .filter-dropdown-remove .svg-icon {
  left: 0.65em;
}

html[dir="rtl"] .filter-dropdown-active {
  padding: 0.51667rem 0.51667rem 0.51667rem 0;
}

image

image

@macandcheese
Copy link
Contributor

macandcheese commented Apr 11, 2018

Thanks for the report - fixed in #942 - also made some slight alignment changes to the filter lists in both RTL and LTR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants