-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation to include examples of ES6-style imports (import * as .... from 'esri-leaflet-geocoder'
)
#293
Comments
Hi, I think that import style is correct when using ES6 import style. |
Import style works, but the way the documentation shows to use it does not. |
Hi, thanks for the feedback. Which documentation are you referring to? |
Under the API Reference section of this repo's README, it shows to use |
Thanks...
Either are valid, but the documentation focuses on number 1 since that is the pattern that most Leaflet users are following. I think your confusion is that number 2 is not really mentioned in the documentation, and that's a fair critique, as more people start to use the |
import * as .... from 'esri-leaflet-geocoder'
)
Note that before we document using this library with ESM, we'll need to get the other Esri Leaflet libraries working with ESM here: Esri/esri-leaflet#1386 So if anyone has time to look into that one ^ it would be much appreciated. |
I installed this project via npm as well as it's types for my Gatsby (react) project, but I am unable to use it thru the leaflet package as the documentation suggests.
I ran
npm i esri-leaflet-geocoder --save
andnpm i @types/esri-leaflet-geocoder --save
which installed properly, but when I go to use the geocode like the documentation suggests:I get a runtime error that
Geocoder
is undefined.I can get around this by importing the package directly:
However, when I do it this way. I run into issues with the api key that I've opened another issue about
The text was updated successfully, but these errors were encountered: