Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pig UDFs #57

Open
mrflip opened this issue Jul 8, 2014 · 4 comments
Open

Pig UDFs #57

mrflip opened this issue Jul 8, 2014 · 4 comments

Comments

@mrflip
Copy link

mrflip commented Jul 8, 2014

I've been working on using the Esri/geometry-api-java to be a spatial framework for Pig -- have just hit the milestone of being able to do a spatial join by splitting on tiles at the mapper then joining two bags of geometries using a quadtree on the reducer.

The work currently lies within my fork of datafu for no other reason than it has a good unit test harness and I'm familiar with it. Since then I've also learned about pigeon.

This repo is probably the obvious home for the code, though. Is that interesting? Do you have feedback on the approach I'm taking?

@climbage
Copy link
Member

climbage commented Jul 8, 2014

This is quite interesting. I've been toying around with the idea of developing Pig equivalents to our Hive UDFs for a while now. I will discuss with our team and see if we can bring this in.

Quick question - is there a reason for some of the functions to take in OGCGeometry and return Geometry? I'll spend more time looking through the functions when I get a another chance.

@randallwhitman
Copy link
Contributor

Grouping the functions by similarities such as method signature makes a lot of sense. We nominally grouped the ST_Geometry for Hive functions into ST_GeometryAccessor, ST_GeometryProcessing, and ST_GeometryRelational; but did not make real use of the base classes until recently. So far havent looked any deeper into your approach.

The developer of Pigeon has also proposed deeper integration with Pig.

@mrflip
Copy link
Author

mrflip commented Jul 10, 2014

Can you give me a sense of when I should use OGCGeometry and when I should use Geometry?

@climbage
Copy link
Member

I would lean towards using OGCGeometry in externally facing APIs. There are some differences in the OGC standard and our implementation that are addressed by the OGCGeometry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants