Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons are Gray When Custom Tab Colors Share any RGB Component with Standard Gray Icon #75

Open
nheick opened this issue Mar 30, 2017 · 0 comments

Comments

@nheick
Copy link

nheick commented Mar 30, 2017

When modifying the colors of the tabs in the web app JSON, if the color has any RGB component that matches the color of the standard gray icon, typically (211, 211, 211), it will not display the icons with the custom color, but will leave them the standard color.

Looking at the code, this appears to be faulty logic in the following line in MainView.buildLayer. There is also an incorrect index in the last iconColor[1].

if(iconColor[0] !=hexToRgb(newIconColor).r && iconColor[1] != hexToRgb(newIconColor).g && iconColor[1] != hexToRgb(newIconColor).b)

The code should read:

if (!(iconColor[0] ==hexToRgb(newIconColor).r && iconColor[1] == hexToRgb(newIconColor).g && iconColor[2] == hexToRgb(newIconColor).b))

I tested this change and it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant