Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow setting reminders on read-only calendars #1368

Open
grrosminet opened this issue Apr 6, 2023 · 2 comments
Open

Do not allow setting reminders on read-only calendars #1368

grrosminet opened this issue Apr 6, 2023 · 2 comments

Comments

@grrosminet
Copy link

On read-only calendars you don't allow to go to edit intent.
you must refuse to set reminders too

(v1.0.34 fdroid )

@devvv4ever
Copy link

I think setting reminders locally could be okay (not sure about what the standard or the Android calendar storage API says). But the event should definitely not be set to "dirty" (which could trigger sending it to the server sometimes which will also cause problems).

@Anachron
Copy link

I don't think modifications should be allowed.

What happens when a user modifies the reminder and the server version gets an updated reminder? Which one to prefer?

As said on the davx5 issue, I suggest to block this and ask the user to create a new reminder elsewhere, as the calendar is read-only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants