Faster set_data() #109
Merged
Faster set_data() #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great @alexander-g ! |
axsaucedo
reviewed
Jan 16, 2021
| strides | ||
| )); | ||
| .def("numpy", [](kp::Tensor& self) { | ||
| return py::array(self.data().size(), self.data().data()); |
There was a problem hiding this comment.
I see, really interesting, I didn't know it could be simplified, looks good
axsaucedo
reviewed
Jan 16, 2021
| const py::array_t<float> flatdata = np.attr("ravel")(data); | ||
| const py::buffer_info info = flatdata.request(); | ||
| const float* ptr = (float*) info.ptr; | ||
| self.setData(std::vector<float>(ptr, ptr+flatdata.size())); |
axsaucedo
approved these changes
Jan 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tensor.set_data()to directly accept a numpy array. Previously arrays were implicitly converted to lists which is slow.numpy()which also results in a small performance boost