Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Loop on log file #705

Closed
bharendt opened this issue Dec 12, 2019 · 5 comments
Closed

Sync Loop on log file #705

bharendt opened this issue Dec 12, 2019 · 5 comments

Comments

@bharendt
Copy link

bharendt commented Dec 12, 2019

Error

When docker sync is started in the background, which is default since 7e32450
rsync logs by deault to ./.docker-sync/daemon.log in the local directory, enabled in d918772.

If the local directory or file is synced, this information is logged to that log file, which causes the log file to be synced itself, which causes another write to the log file and so on. This ends up in a "sync loop" which consumes remarkable CPU resources (depending on the size of the log file which is always appended).

This can be avoided by excluding that log file from syncing in the config file (in sync_excludes), but it might make sense to exclude it already by default or mention it in the default config.

Related: #505 and #369

Docker Driver

d4m

Sync strategy

rsync

OS

OSX

@EugenMayer EugenMayer added the bug label Dec 13, 2019
@EugenMayer
Copy link
Owner

good catch. Providing a exclude default would make a good sense here - are you up for a PR for that little but significant change?

Thank you for the effort!

@EugenMayer EugenMayer changed the title Sync Loop Sync Loop on log file Apr 9, 2020
@yosephsa
Copy link
Contributor

yosephsa commented Sep 9, 2022

@EugenMayer Created an PR fixing this issue. #816

Can I get some help testing the rsync strategy changes? (if not, it may take me a couple days before I can test that locally)

@EugenMayer
Copy link
Owner

@yosephsa
Copy link
Contributor

Tested rsync locally and found an issue. PR created

@EugenMayer
Copy link
Owner

@yoseph1998 thanks! Merged and going to release with 1.0.2 ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants