Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGIPD500K does not have the channel numbers shown in inspect() #223

Closed
daniloefl opened this issue May 30, 2023 · 7 comments · Fixed by #226
Closed

AGIPD500K does not have the channel numbers shown in inspect() #223

daniloefl opened this issue May 30, 2023 · 7 comments · Fixed by #226

Comments

@daniloefl
Copy link

No description provided.

@tmichela
Copy link
Member

I think none of the detector show the channel number in .inspect() (e.g. see AGIPD1M https://extra-geom.readthedocs.io/en/latest/agipd_geometry.html) is this something useful?

@tmichela
Copy link
Member

FYI, the channel mapping is:

module channel
Q1M1 0
Q1M2 1
Q1M3 2
Q1M4 3
Q2M1 4
Q2M2 5
Q2M3 6
Q2M4 7

@philsmt
Copy link
Contributor

philsmt commented May 31, 2023

Note that the quadrant notation is no longer universally used for this detector, replaced by simply enumerating them.

@daniloefl
Copy link
Author

I was thinking of something like this: https://extra-geom.readthedocs.io/en/latest/geometry.html#agipd-1m

Sorry, I thought inspect produced it. If not, can it be produced somehow? This is useful to know what channel goes where looking at the data.

@tmichela
Copy link
Member

Probably @takluyver produced these images, may still have the code to generate them? (we could also add it to the inspect output, that's probably easy enough).

@takluyver
Copy link
Member

That AGIPD-1M diagram was made by hand in Inkscape. You can find the SVG source in this repo:

https://github.com/European-XFEL/EXtra-geom/tree/master/docs/_static

The goal with .inspect() is just to show whatever naming scheme is most likely to be readily understood. If no-one's calling them Q1M1 etc., let's change that. Poking around the HED Karabo GUI, it looks like M0 to M7 would work.

@daniloefl
Copy link
Author

In my particular case, I would be interested in understanding which data goes where, when the detector is assembled. My data is labelled by a numeric array, so I do think it would be relevant to show which module of the detector would correspond to which data index.

But perhaps this is a niche use case. In any case, if you think it is not a big deal, feel free to close the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants