Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT USE THIS THING #120

Open
mmontag opened this issue Sep 27, 2018 · 8 comments
Open

DO NOT USE THIS THING #120

mmontag opened this issue Sep 27, 2018 · 8 comments

Comments

@mmontag
Copy link

mmontag commented Sep 27, 2018

Just a warning to amplify the sentiments of others here and on StackOverflow.

See https://stackoverflow.com/a/46967462/264970

@mmontag mmontag changed the title HIGHLY DISCOURAGED - DO NOT USE THIS THING DO NOT USE THIS THING Sep 27, 2018
@mmontag
Copy link
Author

mmontag commented Sep 27, 2018

If you have already written code against unzip and are having problems, try https://www.npmjs.com/package/unzipper, which should be a drop-in replacement. Worked for me.

@nicolas-cherel
Copy link

whoa, lost a few hours trying to figure out why it was not working for my use case, and it really looked like it wasn't consuming my stream properly. thanks for the reminder :)

@grigorkin
Copy link

Fantastic! I've spent almost a day to find the problem in my code, but the problem was in that lib.

@kalinchernev
Copy link

@mmontag thank you so much for this thread. I did spent hours with issues with this package and unzipper did work as a drop-in replacement without any issues inside modern async code!
Thank you so much!

@shaunwarman
Copy link

Wooh. Thanks!

@Gi60s
Copy link

Gi60s commented Jan 11, 2019

Wow, thanks for this issue. I've been tracing weird file behavior for hours. Couldn't figure out why intermittently I couldn't overwrite a file that had been unzipped. Following this post I think it couldn't overwrite the file because it's file handle was probably still in use.

Thanks a ton @mmontag

@IanDavey
Copy link

Thanks, @mmontag! After spending a day writing code that uses this it's fantastic to have a drop-in replacement.

@dobromyslov
Copy link

@EvanOxfeld I hope you are alive. Could you please mark this package as deprecated? It will help to make NodeJS ecosystem less cluttered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants