Example code for distributing read requests across EventStore DB nodes. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylorph
reviewed
May 1, 2022
|
|
||
| public class EventStoreClientPoolOptions { | ||
| public int MaximumReaderThreads { get; set; } = 3; | ||
| public int MaximumWriterThreads { get; set; } = 1; |
There was a problem hiding this comment.
Since we don't expose the write operation , remove ?
ylorph
reviewed
May 1, 2022
There was a problem hiding this comment.
- Need
- a README containing
- what / how it does the work
- when to use, when to not use.
- caveats / gotchas / limitations if any
- A small program demonstrating usage.
- would be cool if it showed the diff between not using the pool & using it
- a README containing
- samples might be in different languages , need to move this to a .net subfolder
- the readme on the root folder needs to be adapted
- the github actions needs to be adapted
- no tests ?
- I wonder what happens when
- one of the nodes in a cluster would be replaced by a new one (i.e a completely new DNS name / IP address )
- I'm reading a really long stream ( like a category stream )
ylorph
reviewed
May 1, 2022
| _log.LogInformation("Setting leader connection to {@leaderUri}.", leaderUri); | ||
| var grpcClientSettings = EventStoreClientSettings.Create($"{_options.LeaderUri}"); | ||
| grpcClientSettings.DefaultCredentials = _options.DefaultCredentials; | ||
| grpcClientSettings.ConnectivitySettings.NodePreference = Client.NodePreference.Leader; |
There was a problem hiding this comment.
Suggested change
| grpcClientSettings.ConnectivitySettings.NodePreference = Client.NodePreference.Leader; | |
| grpcClientSettings.ConnectivitySettings.NodePreference = NodePreference.Leader; |
Otherwise it does not build
|
Wondering if this should go into the .net client library repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.