Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency with Vulkan API vkCmdSetFragmentShadingRateKHR #9

Open
jayrulez opened this issue Jun 14, 2022 · 2 comments
Open

Inconsistency with Vulkan API vkCmdSetFragmentShadingRateKHR #9

jayrulez opened this issue Jun 14, 2022 · 2 comments

Comments

@jayrulez
Copy link

There seems to be an issue here:

public static void vkCmdSetFragmentShadingRateKHR(VkCommandBuffer commandBuffer, VkExtent2D* pFragmentSize, VkFragmentShadingRateCombinerOpKHR combinerOps)

The vulkan API is

// Provided by VK_KHR_fragment_shading_rate
void vkCmdSetFragmentShadingRateKHR(
    VkCommandBuffer                             commandBuffer,
    const VkExtent2D*                           pFragmentSize,
    const VkFragmentShadingRateCombinerOpKHR    combinerOps[2]);

taking two VkFragmentShadingRateCombinerOpKHR

@jayrulez
Copy link
Author

I have a fix for this in my fork:
jayrulez/Bulkan.Generator@2dcdf05

Perhaps you want it to use it or fix it differently.

@jcant0n
Copy link
Member

jcant0n commented Sep 13, 2022

Hi,

I'm going to review this fix before make this changes.

Thank you for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants