Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the user to save the preprocessed wavs #336

Closed
MENGZHEGENG opened this issue Mar 15, 2024 · 1 comment
Closed

Enable the user to save the preprocessed wavs #336

MENGZHEGENG opened this issue Mar 15, 2024 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@MENGZHEGENG
Copy link
Collaborator

Sometimes the user may be curious about what the audio will be like after our preprocessing steps.

We have an API to enable the user to save preprocessed waves, which is good:
https://github.com/roedoejet/EveryVoice/blob/d117ece5d29947e171bf181bc481c66bb26352ff/everyvoice/preprocessor/preprocessor.py#L121C9-L121C18

I'm sorry that I didn't figure out how to configure save_wave to TRUE in the configuration files.

@roedoejet
Copy link
Member

roedoejet commented Mar 18, 2024

I think we should just only save .wav files, and not .pt. but we can do a benchmark for training speed between .pt and .wav.

@roedoejet roedoejet added this to the beta milestone Mar 18, 2024
@roedoejet roedoejet added bug Something isn't working enhancement New feature or request labels Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants