closes #1451

[akpaevj]

Summary by CodeRabbit

• Bug Fixes
  • Improved the handling of outer scopes to ensure distinct instances of AttachedContext are used, enhancing stability and performance.

[coderabbitai]

Walkthrough

The changes involve an update to the RuntimeScopes class constructor, specifically in how the _outerScopes field is initialized. The previous implementation directly assigned the outerScopes parameter to _outerScopes, while the new implementation uses LINQ's Select method to create a new list of AttachedContext instances. This ensures that _outerScopes contains distinct instances rather than references to the original objects.

Changes

File	Change Summary
src/ScriptEngine/Machine/RuntimeScopes.cs	Updated _outerScopes initialization to use LINQ's Select for creating distinct AttachedContext instances.

Poem

In the code where rabbits play,
Distinct instances hop and sway.
With LINQ's magic, they now gleam,
A list of contexts, like a dream.
Hooray for changes, bright and new,
A joyful leap, we bid adieu! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between e091463 and 3d6d6d6.

📒 Files selected for processing (1)

• src/ScriptEngine/Machine/RuntimeScopes.cs (2 hunks)

🔇 Additional comments (2)

src/ScriptEngine/Machine/RuntimeScopes.cs (2)

11-11: LGTM: Added necessary using statement

The addition of using System.Linq; is appropriate as it's required for the LINQ operations used in the constructor.

---

28-28: Approved, but clarification needed on necessity and performance

The change to create new AttachedContext instances ensures that _outerScopes contains distinct objects rather than references to the original ones. This could prevent unintended modifications to the original outerScopes objects.

However, I have a few questions:

1. Could you clarify why this change was necessary? Are there specific scenarios where modifying the original outerScopes objects caused issues?
2. Have you considered the potential performance impact of this change, especially for large outerScopes lists?

To assess the usage and potential impact, let's analyze the codebase:

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Mr-Rm]

(не успел немного)
Проблема устраняется, но не в том месте, где возникла.
Достаточно в LibraryLoader.AddModule() после строки

OneScript/src/ScriptEngine.HostedScript/LibraryLoader.cs

Line 115 in 4844629

_env.InjectGlobalProperty(null, moduleName, true);

Выполнить повторный Attach для MachineInstance.Current._globalContexts (точнее, для одного _globalContexts[0])

[Mr-Rm]

!
Начал падать tests\eval.os:
ТестДолжен_ПроверитьРекурсивныйВызовВыполнить
ТестДолжен_ПроверитьВызовыВыполнитьСПопытками

[EvilBeaver]

! Начал падать tests\eval.os: ТестДолжен_ПроверитьРекурсивныйВызовВыполнить ТестДолжен_ПроверитьВызовыВыполнитьСПопытками

Забрал себе