Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulation Tests: Connext #1460

Closed
kilrau opened this issue Apr 3, 2020 · 9 comments
Closed

Simulation Tests: Connext #1460

kilrau opened this issue Apr 3, 2020 · 9 comments
Assignees
Labels

Comments

@kilrau
Copy link
Contributor

kilrau commented Apr 3, 2020

Let's flesh out some details @LePremierHomme , but in general it should be similar to the previous raiden test suite, but using ganache instead of geth. Can't find the commit where you deleted all raiden tests, but I bet you can @LePremierHomme . Let's start from there.

@kilrau kilrau added automated tests P2 mid priority labels Apr 3, 2020
@kilrau kilrau changed the title Connext simulation tests Simulation Tests: Connext Apr 3, 2020
@michael1011
Copy link
Contributor

I think we should use ganache for connext tests unless we want to include raiden in the simulation tests again. Easier to setup and maintain.

@LePremierHomme
Copy link
Contributor

The removal of geth/raiden was part of dockerizing the sim tests, since they caused many issues. Here's the commit: 7ad9693
It removed 3 things:

  1. geth setup
  2. raiden setup
  3. test code

If using ganache+connext, it's most likely that only the test code will be reusable.

Where can I find a guide for deploying connext on a local/private network?

@kilrau
Copy link
Contributor Author

kilrau commented Apr 10, 2020

If using ganache+connext, it's most likely that only the test code will be reusable.

Sounds about right.

Where can I find a guide for deploying connext on a local/private network?

https://github.com/ConnextProject/indra#launch-indra-in-developer-mode

@LePremierHomme
Copy link
Contributor

What's xud latest status regarding supporting connext as swap client?

@kilrau
Copy link
Contributor Author

kilrau commented Apr 10, 2020

Close :) #1424

@LePremierHomme
Copy link
Contributor

When it is expected to get merged?

@kilrau
Copy link
Contributor Author

kilrau commented Apr 10, 2020

Within the next 2–3 weeks I would say. But @erkarl can give a more detailed estimation.

Anyhow, thats why this issue is assigned to the next milestone beta.4.

@LePremierHomme
Copy link
Contributor

Ok, so looks like the missing details are rather technical, and i'll be able to know/specify them only once i'll start working on this.

@kilrau kilrau added P1 top priority and removed P2 mid priority labels Apr 27, 2020
@LePremierHomme
Copy link
Contributor

Closed by #1657.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants