include search path is wrong for exiv2 command-line program

[clanmills]

See: #1516. We are building the exiv2 executable with the headers in /usr/local/include/exiv2. It's very desirable to get this fixed for v0.27.5GM. Perhaps we should have v0.27.5 RC3. This is a serious issue.

I have modified the build script on the Mac mini to remove /usr/local/include/exiv2. However this issue can (and will) impact users. In #1516, I proposed:

include_directories( BEFORE SYSTEM include) # for  #include <exiv2/exiv2>

[clanmills]

I'm now unable to reproduce this. So, I'm going to close this for now. It means the v0.27.5 RC2 is good. The conan build issue isn't in our code.

I know there's something wrong. I did:

cd 0.27-maintenance
git pull --rebase
git checkout 0.27-maintenance
rm -rf build ; mkdir build ; cd build ;
cmake .. -DEXIV2_ENABLE_BMFF=1 -DCMAKE_CXX_STANDARD=98 -DCMAKE_CXX_FLAGS=-Wno-deprecated; make
env LD_LIBRARY_PATH=$PWD/bin bin/exiv2 -vV | grep ^exiv2
exiv2 0.27.5.2
exiv2=0.27.5

Then:

curl -LO https://exiv2.org/builds/exiv2-0.27.4-Linux64.tar.gz
tar xzf exiv2-0.27.4-Linux64.tar.gz
sudo cp -R exiv2-0.27.4-Linux64/include/exiv2 /usr/local/include/exiv2
cd ..
rm -rf build ; mkdir build ; cd build ;
cmake .. -DEXIV2_ENABLE_BMFF=1 -DCMAKE_CXX_STANDARD=98 -DCMAKE_CXX_FLAGS=-Wno-deprecated; make
env LD_LIBRARY_PATH=$PWD/bin bin/exiv2 -vV | grep ^exiv2
exiv2 0.27.5.2
exiv2=0.27.5

I'm sure there is something wrong. I'll reopen this (and propose a fix) when I can consistently reproduce this.