Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py pinned versions cause challenges on python >= 3.8 #387

Closed
falkben opened this issue Jul 30, 2020 · 1 comment
Closed

setup.py pinned versions cause challenges on python >= 3.8 #387

falkben opened this issue Jul 30, 2020 · 1 comment

Comments

@falkben
Copy link
Contributor

falkben commented Jul 30, 2020

Exoctk has several libraries pinned that are not easily installable under python 3.8 or conflict with some of our other libraries (specifically scipy & pyyaml) https://github.com/ExoCTK/exoctk/blob/v1.0.0/setup.py#L33

I haven't yet looked through to have an idea of why these dependencies were pinned in such a way.

scipy is probably the thing we need updated the most as versions < 1.3 don't install easily on python 3.8 (requires compiling, which fails on my mac due to fortran issues I haven't tried to debug).

Conda's oldest version which supports 3.8 is 1.3.1. But scipy is currently at 1.5.2 and ideally we'd just use that.

Our requirement for python 3.8 comes from fastapi, which runs best on recent versions of python, though we could use 3.7 if we had to, python 3.9 is just about to come out so I think 3.8 is the correct choice for us at this point.

Currently we are getting install issues with exoctk by pinning the most recent scipy version. However, I'm curious whether that will cause any known issues or, ideally, whether we can get exoctk to pin a scipy version >= 1.3.1?

Thanks!

@nespinoza
Copy link
Collaborator

I think jumping scipy up to >= 1.3.1 shouldn't be too much trouble (we need to check this however). Will discuss it internally in our next team meeting (next week) and let you folks know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants