Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix benches and tests to use Cursor #6

Closed
ExpHP opened this issue Jun 12, 2019 · 0 comments
Closed

Fix benches and tests to use Cursor #6

ExpHP opened this issue Jun 12, 2019 · 0 comments

Comments

@ExpHP
Copy link
Owner

ExpHP commented Jun 12, 2019 •
edited
Loading

This is an interaction between potocpav/npy-rs#15, potocpav/npy-rs#16, and potocpav/npy-rs#17, all of which have effectively been merged in this fork so I can finally work on it!

Basically, potocpav/npy-rs#15 and potocpav/npy-rs#17 added a bunch of benches and tests that wanted to use Cursor<Vec<u8>> (support for which was added in potocpav/npy-rs#16).

Don't forget to remove the entries from .gitignore!
@ExpHP ExpHP added enhancement New feature or request and removed enhancement New feature or request labels Jun 12, 2019
@ExpHP ExpHP closed this as completed in 3a3d545 Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ExpHP