Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix origins reload thread leak #291

Closed
kvosper opened this issue Sep 25, 2018 · 1 comment
Closed

Fix origins reload thread leak #291

kvosper opened this issue Sep 25, 2018 · 1 comment

Comments

@kvosper
Copy link
Contributor

kvosper commented Sep 25, 2018

The problem

When we reload origins in Styx, new thread pools are created but the old ones are not deleted.

Detailed description

There are two places where new thread pools are created:

  • NettyConnectionFactory
  • ScheduledOriginHealthStatusMonitor

These are not currently shut down when new ones are created for the associated back-end service, causing the number of threads to climb ever-upwards. These need to be closed when origins are reloaded, i.e. when the client they are associated with closes.

Acceptance criteria

(/) The thread pool for NettyConnectionFactory is shut down when the object is discarded
(/) The thread pool for ScheduledOriginHealthStatusMonitor is shut down when the object is discarded
@kvosper kvosper mentioned this issue Sep 25, 2018
Merged
@mikkokar
Copy link
Contributor

Fixed in master by PR #290.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikkokar @kvosper