Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance] Sidebar Performance at Scale #10248

Closed
marcaaron opened this issue Aug 4, 2022 · 5 comments
Closed

[Performance] Sidebar Performance at Scale #10248

marcaaron opened this issue Aug 4, 2022 · 5 comments
Assignees
Labels
Daily KSv2 Engineering Planning Changes still in the thought process

Comments

@marcaaron
Copy link
Contributor

What performance issue do we need to solve?

OptionsListUtils and SidebarLinks are pretty slow and the issues get worse as you increase the number of reports.

As recently discovered in this fire.

What is the impact of this on end-users?

Slow boot time, slow chat switching, in some extreme cases inability to use the app.

List any benchmarks that show the severity of the issue

Proposed solution (if any)

Steps we should take in order of priority...

  • Memoization can help with performing unnecessary re-calculations
  • Make more holistic improvements to how options are calculated to remove other bottlenecks
  • Long term we need to implement some kind of pagination

List any benchmarks after implementing the changes to show impacts of the proposed solution (if any)

Note: These should be the same as the benchmarks collected before any changes.

Platform:

I assume everywhere.

Version Number: v1.1.87-8
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork

@marcaaron marcaaron added Engineering Weekly KSv2 Planning Changes still in the thought process labels Aug 4, 2022
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Aug 29, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2022

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@marcaaron marcaaron added Weekly KSv2 and removed Monthly KSv2 labels Aug 29, 2022
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Sep 22, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 22, 2022

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@JmillsExpensify JmillsExpensify added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Oct 18, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2022

Triggered auto assignment to @CortneyOfstad (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed AutoAssignerTriage Auto assign issues for triage to an available triage team member Monthly KSv2 labels Oct 18, 2022
@CortneyOfstad
Copy link
Contributor

@marcaaron Just checking to see if this is still occurring, or if this can be closed? Thanks!

@CortneyOfstad
Copy link
Contributor

@marcaaron appears to be OoO. Closing until they return.

Feel free to reopen if issue is still occurring!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Planning Changes still in the thought process
Projects
None yet
Development

No branches or pull requests

3 participants