Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login - There is No phone number is +15005550006 at the error when typed 2 digits and continue #10257

Closed
kbecciv opened this issue Aug 5, 2022 · 8 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Aug 5, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #8511

Action Performed:

  1. Go to staging.new.expensify.com
  2. Type 2 digits and continue
  3. Verify that the phone number is +15005550006 at the error

Expected Result:

There is phone number is +15005550006 at the error when typed 2 digits and continue

Actual Result:

There is No phone number is +15005550006 at the error when typed 2 digits and continue

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.88.1

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): none

Logs: https://stackoverflow.com/c/expensify/questions/4856

Recording.896.mp4

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Aug 5, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Aug 5, 2022

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 5, 2022

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@johnmlee101
Copy link
Contributor

@kbecciv the video evidence for this is for a different issue? I cannot reproduce otherwise

@kbecciv
Copy link
Author

kbecciv commented Aug 5, 2022

@johnmlee101 Sorry about that, updated correct video.

Recording.896.mp4

@johnmlee101
Copy link
Contributor

Okay to clarify the issue is that the error message doesn't pop up for invalid numbers, not that "No phone number is +15005550006"

@johnmlee101
Copy link
Contributor

I think this is caused by cd40818 cc @yuwenmemon

@yuwenmemon yuwenmemon assigned yuwenmemon and unassigned johnmlee101 Aug 5, 2022
@yuwenmemon
Copy link
Contributor

Okay looked into this for a bit, but a lot has changed (and is changing) with regards to error handling and Onyx so I'm just going to revert that previous PR to get the error handling right

@yuwenmemon
Copy link
Contributor

Reverted the offending PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants