-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login - There is No phone number is +15005550006 at the error when typed 2 digits and continue #10257
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @johnmlee101 ( |
@kbecciv the video evidence for this is for a different issue? I cannot reproduce otherwise |
@johnmlee101 Sorry about that, updated correct video. Recording.896.mp4 |
Okay to clarify the issue is that the error message doesn't pop up for invalid numbers, not that "No phone number is +15005550006" |
I think this is caused by cd40818 cc @yuwenmemon |
Okay looked into this for a bit, but a lot has changed (and is changing) with regards to error handling and Onyx so I'm just going to revert that previous PR to get the error handling right |
Reverted the offending PR |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found when executing PR #8511
Action Performed:
Expected Result:
There is phone number is +15005550006 at the error when typed 2 digits and continue
Actual Result:
There is No phone number is +15005550006 at the error when typed 2 digits and continue
Workaround:
Unknown
Platform:
Where is this issue occurring?
Version Number: 1.1.88.1
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): none
Logs: https://stackoverflow.com/c/expensify/questions/4856
Recording.896.mp4
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: