Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS/Safari - The smart banner is NOT shown on all pages #10259

Closed
kavimuru opened this issue Aug 5, 2022 · 3 comments
Closed

iOS/Safari - The smart banner is NOT shown on all pages #10259

kavimuru opened this issue Aug 5, 2022 · 3 comments
Assignees

Comments

@kavimuru
Copy link

kavimuru commented Aug 5, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing #10070

Action Performed:

  1. Open the app in mWeb Safari
  2. Check for availability The smart banner

Expected Result:

The smart banner is shown on all pages

Actual Result:

The smart banner is NOT shown on workspace settings page and from FAB (New chat, New group and New room)

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Mobile Web

Version Number: v1.1.88-1
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5676817_Image_from_iOS__2_.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Aug 5, 2022

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@pecanoro pecanoro mentioned this issue Aug 5, 2022
93 tasks
@pecanoro
Copy link
Contributor

pecanoro commented Aug 5, 2022

We are reverting the PR so we can close this one #10070

@parasharrajat
Copy link
Member

parasharrajat commented Aug 5, 2022

I think leaving a note on the main issue will also be helpful that PR is reverted due to regression.

cc: @pecanoro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants