Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Mac / Safari - Unread favicon - No unread favicon in the browser tab #10528

Closed
kavimuru opened this issue Aug 24, 2022 · 10 comments
Closed
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing #10041

Action Performed:

1 Login to the ND under Web/Safari as user A.
2. send DM to the user A
3. Observe favicon for the corresponding tab in the browser

Expected Result:

The user should see a new Favicon if there are unread messages

Actual Result:

Describe what actually happened
Favicon has no Unread mark if unread messages are present

Only on Safari. Chrome is OK

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web - Safari

Version Number: v1.1.89-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5702224_Screenshot_2022-08-24_at_16 28 02

Bug5702224_Screen_Recording_2022-08-24_at_16.23.55.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Aug 24, 2022

Triggered auto assignment to @cristipaval (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@cristipaval
Copy link
Contributor

Monthly - because even if the "unread" icon is not visible, there is that (x) suffix in the tab title which lets the user know that there are unread messages.

Other than that, @robertjchen I know you changed the favicon recently. Do you have more context on this? I think this could be externalised, what do you think?

@cristipaval cristipaval removed their assignment Aug 26, 2022
@robertjchen
Copy link
Contributor

Yeah, that's odd. I don't think swapping out the favicon could've caused this. Maybe it's a Safari-related bug? Let's externalize this for further investigation 👍

@robertjchen robertjchen added the External Added to denote the issue can be worked on by a contributor label Sep 2, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 2, 2022

Triggered auto assignment to @bfitzexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels Sep 2, 2022
@bfitzexpensify
Copy link
Contributor

Upwork job here

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Sep 2, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 2, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 2, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 2, 2022

Triggered auto assignment to @aldo-expensify (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot changed the title Mac / Safari - Unread favicon - No unread favicon in the browser tab [$250] Mac / Safari - Unread favicon - No unread favicon in the browser tab Sep 2, 2022
@wildan-m
Copy link
Contributor

wildan-m commented Sep 8, 2022

It wouldn't be possible.

They purposefully don't allow dynamic changes/animations to the favicon

https://stackoverflow.com/questions/63781987/cant-change-favicon-with-javascript-in-safari

https://bugs.webkit.org/show_bug.cgi?id=75877

Other dynamic favicon samples that work on Chrome but will not work on Safari:
https://mathiasbynens.be/demo/dynamic-favicons
http://lab.ejci.net/favico.js/example-simple/

@robertjchen
Copy link
Contributor

Got it, thanks for looking into this!

@bfitzexpensify
Copy link
Contributor

OK, since this won't be possible to fix, we'll go ahead and close it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants