Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - Cursor appears to be behind the first letter of placeholder text #10604

Closed
kavimuru opened this issue Aug 26, 2022 · 6 comments
Closed

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. open the test app
  2. sign in to any account
  3. click the green + icon and select request money
  4. enter any amount and click next
  5. select any user
  6. observe the cursor at the What's it for? field

Expected Result:

The cursor is not displayed behind the first letter of the placeholder text at the What's it for? field.

Actual Result:

The cursor is displayed behind the first letter of the placeholder text at the What's it for? field.

Workaround:

Visual

Platform:

Where is this issue occurring?

  • iOS (overlaps with the 1st letter of placeholder text)
  • Android

Version Number: 1.1.92-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
In iOS

In android

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Aug 26, 2022

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2022

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

@Beamanator
Copy link
Contributor

@shawnborton would you please check out this issue and let me know if you think it's worth fixing? I'm leaning toward no, I don't mind if the cursor is slightly overlapping & looks a bit behind the placeholder text, but I don't think I have a good eye for design haha

@melvin-bot melvin-bot bot removed the Overdue label Aug 29, 2022
@Beamanator Beamanator added Weekly KSv2 and removed Daily KSv2 labels Aug 29, 2022
@shawnborton
Copy link
Contributor

This is similar to the money request screen cursor issue, we should combine these into one issue as it's the same "bug"

If we can find an easy way to fix this, I am all for it. Google does something similar with material design so maybe we can get some ideas there.

Otherwise we just move the "Optional" part into the label, like What's it for? (Optional) but it's not quite as clean

And of course, we do have the option to do nothing... I don't mind it that much but let's investigate first.

@melvin-bot

This comment was marked as off-topic.

@Beamanator
Copy link
Contributor

Makes sense @shawnborton - thanks for catching this as a dupe!

I'll let contributors come up with ideas in the other issue you linked and I'll close this one out 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants