Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace - The Workspace editor page isn't open after creating the new workspace. #10605

Closed
kbecciv opened this issue Aug 26, 2022 · 7 comments
Assignees
Labels
Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Aug 26, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Create a new applause.expensifail account on staging.new.expensify.com
  2. Click on Create a New Workspace

Expected Result:

The Workspace editor page should be open after creating the new workspace.

Actual Result:

The Workspace editor page isn't open after creating the new workspace.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.92.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5705659_WS_new2.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Aug 26, 2022

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Aug 30, 2022

@cead22 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@cead22 cead22 removed the Overdue label Aug 30, 2022
@cead22 cead22 removed their assignment Aug 30, 2022
@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 30, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 30, 2022

Triggered auto assignment to @jasperhuangg (Demolition), see https://stackoverflow.com/c/expensify/questions/8099 for more details.

@cead22
Copy link
Contributor

cead22 commented Aug 30, 2022

Labeling Demolition instead of External since this is something we should fix asap

@jasperhuangg
Copy link
Contributor

Can confirm this is happening locally, taking a look

@jasperhuangg
Copy link
Contributor

jasperhuangg commented Aug 31, 2022

Found the problem, it's because of this incorrect usage of Promise.all that was added here cc @arosiclair

Promise.all takes an iterable of promises, not the individual promises as arguments. Simply passing in the promises as an array fixes things. PR in the works.

@melvin-bot
Copy link

melvin-bot bot commented Aug 31, 2022

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

3 participants