Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [$1000] Android - Split/Send/Request money - The transition is not smooth when requesting/split amount #10610

Closed
kbecciv opened this issue Aug 26, 2022 · 32 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2 Needs Reproduction Reproducible steps needed

Comments

@kbecciv
Copy link

kbecciv commented Aug 26, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Login with any chat
  3. Go to any group conversation or chat
  4. Click the + icon
  5. Select Split Bill/Send Money/Request Money
  6. Enter an amount and select the Next confirmation button

Expected Result:

The transition should be smooth

Actual Result:

The transition is not smooth

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Mobile Web

Version Number: 1.1.92.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5705912_video_2022-08-27_00-16-16.mp4
Bug5705912_video_2022-08-27_00-14-44.mp4
Bug5705912_video_2022-08-27_00-13-26.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Aug 26, 2022

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Aug 30, 2022

@robertjchen Whoops! This issue is 2 days overdue. Let's get this updated quick!

@robertjchen
Copy link
Contributor

I'm not sure I see the issue here w/ "The transition is not smooth". Do you have the original Slack discussion or a more detailed description for additional context?

@melvin-bot melvin-bot bot removed the Overdue label Aug 30, 2022
@robertjchen robertjchen added Monthly KSv2 and removed Daily KSv2 labels Aug 30, 2022
@isagoico
Copy link

isagoico commented Sep 1, 2022

@robertjchen hello! The transitions between modals is included in our scope when testing the regression. In the video it can be seen that the loading of the Big Number Pad page is glitchy (it's kinda hard to put it into words haha).

If these types of bugs related to transitions are not in scope please let us know and we'll inform the team.

@robertjchen
Copy link
Contributor

Ahh, I think I see it now! These issues are definitely in scope as we want to make the app as well-polished as possible 😉 Let me open this up to our contributors to see if there's a proposal to make it better 🙏

@robertjchen robertjchen added Weekly KSv2 External Added to denote the issue can be worked on by a contributor and removed Weekly KSv2 labels Sep 2, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 2, 2022

Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels Sep 2, 2022
@jboniface jboniface self-assigned this Sep 5, 2022
@jboniface
Copy link

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Sep 5, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 5, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 5, 2022
@dylanexpensify
Copy link
Contributor

Yes! Shall we close then @marcochavezf ?

@melvin-bot melvin-bot bot removed the Overdue label Sep 27, 2022
@marcochavezf
Copy link
Contributor

@dylanexpensify Ah I think only the Upwork job, because the problem exists, and we'd want to re-evaluate the issue after the Keyboard initiative is implemented.

@marcochavezf marcochavezf added Monthly KSv2 and removed Daily KSv2 labels Sep 27, 2022
@JmillsExpensify JmillsExpensify changed the title [HOLD Keyboard Initiative][$500] Android - Split/Send/Request money - The transition is not smooth when requesting/split amount [HOLD #10273][$500] Android - Split/Send/Request money - The transition is not smooth when requesting/split amount Sep 27, 2022
@JmillsExpensify JmillsExpensify changed the title [HOLD #10273][$500] Android - Split/Send/Request money - The transition is not smooth when requesting/split amount [HOLD #10273] [BUG] [$500] Android - Split/Send/Request money - The transition is not smooth when requesting/split amount Sep 29, 2022
@JmillsExpensify JmillsExpensify changed the title [HOLD #10273] [BUG] [$500] Android - Split/Send/Request money - The transition is not smooth when requesting/split amount [HOLD #10273] [Bug] [$500] Android - Split/Send/Request money - The transition is not smooth when requesting/split amount Oct 19, 2022
@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 31, 2022
@dylanexpensify
Copy link
Contributor

not overdue

@JmillsExpensify
Copy link

Snagging this from you @dylanexpensify since I'm on the tracking issue.

@JmillsExpensify
Copy link

Now that the keyboard initiative is kicked off, I'm removing the hold.

@JmillsExpensify JmillsExpensify changed the title [HOLD #10273] [Bug] [$500] Android - Split/Send/Request money - The transition is not smooth when requesting/split amount [Bug] [$500] Android - Split/Send/Request money - The transition is not smooth when requesting/split amount Nov 2, 2022
@JmillsExpensify
Copy link

@tgolen Shall you take this one from @marcochavezf as well, since you're leading the tracking issue?

@JmillsExpensify
Copy link

Whatever the case, the old Upwork job expired so I have created a new one and also raised the price to $1000 given that this is a mainline initiative for WAQ. https://www.upwork.com/jobs/~0123070f67b356c4b3

@JmillsExpensify JmillsExpensify changed the title [Bug] [$500] Android - Split/Send/Request money - The transition is not smooth when requesting/split amount [Bug] [$1000] Android - Split/Send/Request money - The transition is not smooth when requesting/split amount Nov 2, 2022
@JmillsExpensify
Copy link

One final note. @applausebot can you help me re-test this as well, as I don't have an Android device I'm able to test with.

@tgolen tgolen assigned tgolen and unassigned marcochavezf Nov 2, 2022
@tgolen
Copy link
Contributor

tgolen commented Nov 2, 2022

Sure, I'll take this over.

@JmillsExpensify JmillsExpensify added the Needs Reproduction Reproducible steps needed label Nov 6, 2022
@JmillsExpensify
Copy link

You know what, I think we are done here. I just tested this and the bouncing caused by the keyboard no longer exists. I'm attaching a video of my test just now.

RPReplay_Final1667767622.MP4

@JmillsExpensify
Copy link

Given that I'm unable to reproduce I'm closing this issue. Another keyboard issue bites the dust!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2 Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests