Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$2000] When you long-press on a message, the message moves out of the screen frame and is hidden #10632

Open
mvtglobally opened this issue Aug 29, 2022 · 91 comments
Assignees
Labels
Engineering NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@mvtglobally
Copy link

mvtglobally commented Aug 29, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to any chat with multiple messages
  2. Long press on the last message you sent

Expected Result:

When long pressing on the last message, we should adjust the scroll so that the message you just selected is visible.

Actual Result:

When you long-press on a message in iOS mobile, the message moves out of the screen frame and is hidden.

Workaround:

None

Platform:

Where is this issue occurring?

  • iOS
  • Android

Version Number: 1.1.92-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1661747398.MP4

Expensify/Expensify Issue URL:
Issue reported by: @roryabraham
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661612352759039

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2022

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@melvin-bot melvin-bot bot added the Overdue label Aug 31, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 1, 2022

@marcaaron Whoops! This issue is 2 days overdue. Let's get this updated quick!

@marcaaron
Copy link
Contributor

User should be able to see which messages is being selected

What does this mean exactly... ? Looking at the video and I'm not even sure what the bug is.

@melvin-bot melvin-bot bot removed the Overdue label Sep 4, 2022
@marcaaron
Copy link
Contributor

When you long-press on a message in iOS mobile, the message moves out of the screen frame, and it’s not obvious which message you’ve selected

Also don't understand what is being proposed here.

@marcaaron marcaaron added Monthly KSv2 and removed Daily KSv2 labels Sep 4, 2022
@marcaaron marcaaron assigned roryabraham and unassigned marcaaron Sep 4, 2022
@roryabraham
Copy link
Contributor

The problem is that once the context menu pops up and the modal blur is applied, it's not clear which message you've long-pressed on. What I was imagining is that the message you selected would have a white background / be "immune" from the modal blur effect.

But I think a mockup would be very helpful here. @marcaaron suggested that we could use a "shimmer effect" as an alternative

@roryabraham roryabraham added Weekly KSv2 Monthly KSv2 Design and removed Monthly KSv2 labels Sep 5, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 5, 2022

Triggered auto assignment to @michelle-thompson (Design), see these Stack Overflow questions for more details.

@michelle-thompson
Copy link
Contributor

Hmm, what about when you hold down on a message the background highlights as grey like so?
image

@melvin-bot melvin-bot bot added the Overdue label Sep 19, 2022
@roryabraham
Copy link
Contributor

Yeah, that works! We'll also need to make sure that we:

  • Scroll the chat view so that the highlighted chat is visible despite the context menu opening
  • Make sure we un-highlight the option when the context menu closes

@melvin-bot melvin-bot bot removed the Overdue label Sep 21, 2022
@roryabraham
Copy link
Contributor

Leaving you assigned so that you get the GH points @michelle-thompson

@melvin-bot melvin-bot bot added the Overdue label Sep 29, 2022
@roryabraham roryabraham added the External Added to denote the issue can be worked on by a contributor label Sep 30, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 30, 2022

Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@kirillzyusko
Copy link
Contributor

@hannojg @JmillsExpensify I think this problem can be fixed using react-native-keyboard-controller and its components (KeyboardAvoidingView etc.). I will try to do it 👍

Copy link

melvin-bot bot commented Nov 3, 2023

📣 @kirillzyusko! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@JmillsExpensify
Copy link

Whoops, sorry missed this one. Sound great!

@JmillsExpensify
Copy link

Waiting to be picked up

@kirillzyusko
Copy link
Contributor

Contributor details
Your Expensify account email: kiryl@margelo.io
Upwork Profile Link:

@kirillzyusko
Copy link
Contributor

This is being worked on in this PR: #16356

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Monthly KSv2 labels Jan 26, 2024
@roryabraham roryabraham changed the title [$2000] When you long-press on a message in iOS mobile, the message moves out of the screen frame and is hidden [$2000] When you long-press on a message, the message moves out of the screen frame and is hidden Jan 26, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Mar 14, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels May 14, 2024
@JmillsExpensify
Copy link

This has since moved to this PR: #42143

@hannojg
Copy link
Contributor

hannojg commented Jun 12, 2024

After switching to the new arch we've encountered a bug in reanimated on the fabric renderer.
We are currently trying to solve it to move on with this issue:

Discussed here

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 30, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Aug 8, 2024
@perunt
Copy link
Contributor

perunt commented Aug 30, 2024

Hey @shawnborton, I left a message here to clarify this PR. I look forward to your answer

@luacmartins
Copy link
Contributor

Assigning myself to cover for Rory while he's on parental leave

@luacmartins luacmartins self-assigned this Oct 10, 2024
Copy link

melvin-bot bot commented Nov 27, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests