Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hold for Payment] Url is broken when /settings/security/password or /settings/security/closeAccount is closed - Reported by @aneequeahmad #10887

Closed
mvtglobally opened this issue Sep 8, 2022 · 16 comments
Assignees
Labels
Daily KSv2

Comments

@mvtglobally
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open web app https://new.expensify.com/
  2. Click on user icon on LHN to open setting.
  3. Click on security on RHN.
  4. Click change password or close account.
  5. Close RHN by clicking cross or clicking outside.

Expected Result:

Url should be r/reportID

Actual Result:

Url is /settings/security

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.1.96-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2022-08-24.at.1.43.56.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @aneequeahmad
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661287351063199

View all open jobs on GitHub

@mvtglobally mvtglobally added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Sep 8, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 8, 2022

Triggered auto assignment to @sonialiap (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot added Overdue and removed AutoAssignerTriage Auto assign issues for triage to an available triage team member labels Sep 8, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 13, 2022

@sonialiap Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot
Copy link

melvin-bot bot commented Sep 15, 2022

@sonialiap 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@parasharrajat
Copy link
Member

Related #10952 (comment)

@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2022

@sonialiap 10 days overdue. I'm getting more depressed than Marvin.

@sonialiap
Copy link
Contributor

back from OOO, looking at this now

@melvin-bot melvin-bot bot removed the Overdue label Sep 19, 2022
@sonialiap
Copy link
Contributor

I'm not able to reproduce the steps in this issue, but I am able to reproduce the steps in this one #10952 which covers the same or very similar issue. Closing in favor of #10952

@aneequeahmad
Copy link
Contributor

@sonialiap This navigation issue is fixed in latest production. Reporting bonus payment is pending as per this comment

Attaching screen recording for verification. Thanks

url-bug-fix.mov

cc: @jasperhuangg

@jasperhuangg jasperhuangg reopened this Feb 16, 2024
@jasperhuangg
Copy link
Contributor

Feel free to close out the issue if payment was issued/no next steps need to be taken.

@sonialiap
Copy link
Contributor

@aneequeahmad the link you shared is to a GH search rather than a comment. Could you please share the correct link so that I can take a look?

@aneequeahmad
Copy link
Contributor

@sonialiap apologies here is the link of comment.

@melvin-bot melvin-bot bot added the Overdue label Feb 19, 2024
@sonialiap
Copy link
Contributor

@aneequeahmad Thanks! Offer sent

Reporting $50 - offer sent

https://www.upwork.com/jobs/~01da946f1c0e7020a1

@melvin-bot melvin-bot bot removed the Overdue label Feb 19, 2024
@sonialiap sonialiap changed the title Url is broken when /settings/security/password or /settings/security/closeAccount is closed - Reported by @aneequeahmad [Hold for Payment] Url is broken when /settings/security/password or /settings/security/closeAccount is closed - Reported by @aneequeahmad Feb 19, 2024
@aneequeahmad
Copy link
Contributor

@sonialiap Shouldn't the offer be $250 ? since at the time of reporting bug this was the amount for each bug report.

@sonialiap
Copy link
Contributor

Apologies, I didn't pay attention to the year the issue was opened, what a delay in payment request! You're correct, the reporting bonus is $250 for this. I've updated offer to $250

@aneequeahmad
Copy link
Contributor

@sonialiap Great, Accepted the offer. Thanks for mentioning.

@sonialiap
Copy link
Contributor

Paid ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2
Projects
None yet
Development

No branches or pull requests

5 participants