[HOLD for payment 2022-10-04] [$250] Android - "Close account" button partially covers the text information when keypad opened

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the App/Android and login
2. Go to Settings->Security->Close account
3. Focus on "Enter message" field and then "Enter default method" field

Expected Result:

1. "Close account" button covers the text information when focusing in "Enter message" field;
2. "Close account" button is very near with "Enter default method" field.

Actual Result:

The input fields and the button should not overlap and be too close to each other

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Android

Version Number: v1.1.98-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/189174390-bcca3295-8cf3-4937-9835-68aa80bd9192.mp4
Upwork job URL: https://www.upwork.com/jobs/~015819339bfc73c40e
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

@michaelhaxhiu Whoops! This issue is 2 days overdue. Let's get this updated quick!

[kakajann]

Proposal

This issue occurs on iOS too.

1. "Close account" button covers the text information when focusing in "Enter message" field;

This is IMO expected behaviour, but I suggest reducing number of lines of Enter message here input to be 4. Current value is 6.

This is for non-iOS devices.

- numberOfLines={6}
+ numberOfLines={4}

This is for iOS

closeAccountMessageInput: {
- height: 153,
+ height: 103,
},

Before

Screen.Recording.2022-09-13.at.9.26.25.PM.mov

After

Screen.Recording.2022-09-13.at.9.27.21.PM.mov

2. "Close account" button is very near with "Enter default method" field.

Because the button has no padding-top. Add this:

- <FixedFooter>
+ <FixedFooter style={[styles.pt5]}>

Before	After

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (Exported)

[melvin-bot]

Triggered auto assignment to @marcochavezf (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[michaelhaxhiu]

Note @mananjadhav -- we have a solution proposal above already, which was provided by @kakajann. Let's start there in terms of reviewing proposals.

[mananjadhav]

@marcochavezf @michaelhaxhiu I am fine with @kakajann's proposal if we're okay to reduce the height of the text input. But please note that this issue might still persist when we have smaller height devices. @kakajann Did you check if your proposal works on smaller devices like iPhone SE?

[kakajann]

1st issue is expected behavior though. Here's how it appears on iPhone SE (3rd generation)

[mananjadhav]

1st issue is expected behavior though.

Exactly. Thanks @kakajann. I think we should just focus on the second part of the issue. We can still reduce the number of lines so that it works fine for most devices (off lately all iOS devices from 8 onwards have a good large screen, excluding minis).

Thoughts? @michaelhaxhiu @marcochavezf. Nevertheless, @kakajann's proposal is good for me.

🎀 👀 🎀 
C+ reviewed

[michaelhaxhiu]

cc @Expensify/design for input on adjusting the text input to accomplish this change. Does that seem kosher?

[shawnborton]

Hmm I think we had some open discussion about not making the bottom-docked button cover any of the content? Basically this conversation here.

cc @parasharrajat

[kakajann]

@shawnborton is this what we want here?

Screen.Recording.2022-09-16.at.7.38.32.AM.mov

[shawnborton]

That looks perfect, thanks!

[mananjadhav]

That looks perfect, thanks!

I've taken @shawnborton's comment here as a 🟢 to @kakajann's proposal and the fact that he has updated the proposals on feedback and raised the PR.

[marcochavezf]

Oh I forgot to assign @kakajann to the issue here, thanks for the proposal and the PR!

[melvin-bot]

📣 @kakajann You have been assigned to this job by @marcochavezf!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.7-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Android - "Close account" button partially covers the text information when keypad opened #11071

If no regressions arise, payment will be issued on 2022-10-04. 🎊

[michaelhaxhiu]

@kakajann invited you to the job in upwork, can you accept when you have a chance?

[kakajann]

Just accepted

[melvin-bot]

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[michaelhaxhiu]

@kakajann is paid.

@mananjadhav please apply to this new job today (link) , since the OG job expired

[michaelhaxhiu]

Everyones paid. 😎✌️ Keep it coming folks!