Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2022-11-09] [$250] Web - Clicking on zoom photo line should zoom the photo and the large green button should be place at clicked point reported by @aneequeahmad #10950

Closed
kavimuru opened this issue Sep 13, 2022 · 51 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Click on use icon to open setting page.
  2. Click on any workspace > general settings > edit photo > upload photo.
  3. Click on the the zoom line

Expected Result:

Should zoom image and drag the green button to clicked point

Actual Result:

Not zooming image and dragging the green button.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: v1.1.99-4
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/189779379-a51506f4-1646-4f9f-a79b-9b946af9e27e.mp4
Expensify/Expensify Issue URL:
Issue reported by: @aneequeahmad
Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added AutoAssignerTriage Auto assign issues for triage to an available triage team member Engineering Daily KSv2 labels Sep 13, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 13, 2022

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kavimuru kavimuru changed the title Web - Clicking on zoom photo line should zoom the photo and the large green button should be place at clicked point reported by @@aneequeahmad Web - Clicking on zoom photo line should zoom the photo and the large green button should be place at clicked point reported by @aneequeahmad Sep 13, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 13, 2022

Triggered auto assignment to @maddylewis (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Sep 13, 2022
@varshamb
Copy link
Contributor

varshamb commented Sep 13, 2022

Proposal

We should use Component Slider from '@react-native-community/slider'
I will give detailed proposal if it is okay to use this.

@tgolen
Copy link
Contributor

tgolen commented Sep 13, 2022

@varshamb We typically don't use external components since most things can be built pretty easily and specifically just for our use case. Could you make a proposal that is an improvement to our current <Slider> instead?

@laurenreidexpensify
Copy link
Contributor

Can confirm that this is reproducible.

@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2022

@tgolen, @laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Sep 19, 2022
@laurenreidexpensify
Copy link
Contributor

@tgolen is this good to get the exported label?

@melvin-bot melvin-bot bot removed the Overdue label Sep 19, 2022
@tgolen tgolen added the External Added to denote the issue can be worked on by a contributor label Sep 19, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2022

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

@laurenreidexpensify
Copy link
Contributor

@laurenreidexpensify
Copy link
Contributor

heh why isn't this adding a C+

@thesahindia
Copy link
Member

Maybe because we don't have the help wanted label here

@Beamanator Beamanator added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor labels Sep 20, 2022
@mallenexpensify mallenexpensify self-assigned this Oct 22, 2022
@mallenexpensify
Copy link
Contributor

@laurenreidexpensify co-assigning cuz I'm part of
[Tracking] [Polish] Image-related feature request and improvements #10894

@mananjadhav
Copy link
Collaborator

@Abdallah-Ahmed-moh quick bump on this PR comment

@Abdallah-Ahmed-moh Got a chance to look at this comment?

@mallenexpensify
Copy link
Contributor

@Beamanator This job is in progress so I'm not putting on hold pending #10894.
Comment if you disagree

@Beamanator
Copy link
Contributor

Agreed @mallenexpensify 👍

@melvin-bot
Copy link

melvin-bot bot commented Oct 31, 2022

BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:

  • A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here:
  • The PR that introduced the bug has been identified. Link to the PR:
  • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • Payment has been made to the issue reporter (if applicable)
  • Payment has been made to the contributor that fixed the issue (if applicable)
  • Payment has been made to the contributor+ that helped on the issue (if applicable)

@melvin-bot

This comment was marked as duplicate.

1 similar comment
@melvin-bot

This comment was marked as duplicate.

@laurenreidexpensify
Copy link
Contributor

@Abdallah-Ahmed-moh can you confirm your name in Upwork for me to send you the hiring contract? Thanks

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 2, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 2, 2022

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.22-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2022-11-09. 🎊

@melvin-bot melvin-bot bot changed the title [$250] Web - Clicking on zoom photo line should zoom the photo and the large green button should be place at clicked point reported by @aneequeahmad [HOLD for payment 2022-11-09] [$250] Web - Clicking on zoom photo line should zoom the photo and the large green button should be place at clicked point reported by @aneequeahmad Nov 2, 2022
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 9, 2022
@laurenreidexpensify
Copy link
Contributor

@mananjadhav @Abdallah-Ahmed-moh @aneequeahmad apologies, there was an issue with the Upwork job posting.

The new post is here https://www.upwork.com/jobs/~0135a64425b4d685b1

Please apply and I will issue payment as soon as you have signed the contract

@aneequeahmad
Copy link
Contributor

@laurenreidexpensify I have applied, thanks for mentioning

@mananjadhav
Copy link
Collaborator

Applied @laurenreidexpensify

@laurenreidexpensify
Copy link
Contributor

Still waiting on @Abdallah-Ahmed-moh to apply in Upwork, everyone else has been paid

@Abdallah-Ahmed-moh
Copy link
Contributor

Ok i have apply on upwork on the new post..

@mananjadhav
Copy link
Collaborator

@laurenreidexpensify Quick bump on the above comment, so that we can get this one closed out.

@laurenreidexpensify
Copy link
Contributor

@Abdallah-Ahmed-moh can you please send me a link to your Upwork profile so I can confirm I am paying the correct person? Thanks

@Abdallah-Ahmed-moh
Copy link
Contributor

@laurenreidexpensify the upwork is working for my Identity verification , i will tell you while finish
WhatsApp Image 2022-11-15 at 3 02 51 PM

@Abdallah-Ahmed-moh
Copy link
Contributor

@Abdallah-Ahmed-moh can you please send me a link to your Upwork profile so I can confirm I am paying the correct person? Thanks

https://www.upwork.com/freelancers/~01d7c9c17e7faeaa3e

this is my profile, sorry for being late.

@mananjadhav
Copy link
Collaborator

@laurenreidexpensify Can you help with the above here and closure of the issue?

@laurenreidexpensify
Copy link
Contributor

@Abdallah-Ahmed-moh contract sent in Upwork, please accept so I can proceed with payment! Thanks

@Abdallah-Ahmed-moh
Copy link
Contributor

@laurenreidexpensify i accepted your offer.

@laurenreidexpensify
Copy link
Contributor

Everyone has been paid 🎉 Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

13 participants