-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2022-11-09] [$250] Web - Clicking on zoom photo line should zoom the photo and the large green button should be place at clicked point reported by @aneequeahmad #10950
Comments
Triggered auto assignment to @tgolen ( |
Triggered auto assignment to @maddylewis ( |
ProposalWe should use Component |
@varshamb We typically don't use external components since most things can be built pretty easily and specifically just for our use case. Could you make a proposal that is an improvement to our current |
Can confirm that this is reproducible. |
@tgolen, @laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@tgolen is this good to get the exported label? |
Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new. |
heh why isn't this adding a C+ |
Maybe because we don't have the |
@laurenreidexpensify co-assigning cuz I'm part of |
@Abdallah-Ahmed-moh Got a chance to look at this comment? |
@Beamanator This job is in progress so I'm not putting on hold pending #10894. |
Agreed @mallenexpensify 👍 |
BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:
|
This comment was marked as duplicate.
This comment was marked as duplicate.
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
@Abdallah-Ahmed-moh can you confirm your name in Upwork for me to send you the hiring contract? Thanks |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.22-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2022-11-09. 🎊 |
@mananjadhav @Abdallah-Ahmed-moh @aneequeahmad apologies, there was an issue with the Upwork job posting. The new post is here https://www.upwork.com/jobs/~0135a64425b4d685b1 Please apply and I will issue payment as soon as you have signed the contract |
@laurenreidexpensify I have applied, thanks for mentioning |
Applied @laurenreidexpensify |
Still waiting on @Abdallah-Ahmed-moh to apply in Upwork, everyone else has been paid |
Ok i have apply on upwork on the new post.. |
@laurenreidexpensify Quick bump on the above comment, so that we can get this one closed out. |
@Abdallah-Ahmed-moh can you please send me a link to your Upwork profile so I can confirm I am paying the correct person? Thanks |
@laurenreidexpensify the upwork is working for my Identity verification , i will tell you while finish |
https://www.upwork.com/freelancers/~01d7c9c17e7faeaa3e this is my profile, sorry for being late. |
@laurenreidexpensify Can you help with the above here and closure of the issue? |
@Abdallah-Ahmed-moh contract sent in Upwork, please accept so I can proceed with payment! Thanks |
@laurenreidexpensify i accepted your offer. |
Everyone has been paid 🎉 Closing |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Should zoom image and drag the green button to clicked point
Actual Result:
Not zooming image and dragging the green button.
Workaround:
Unknown
Platform:
Where is this issue occurring?
Version Number: v1.1.99-4
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/189779379-a51506f4-1646-4f9f-a79b-9b946af9e27e.mp4
Expensify/Expensify Issue URL:
Issue reported by: @aneequeahmad
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: